Change in flashrom[staging]: fixup! Convert flashrom to git - flashrom-gerrit

1 Oct 2017


      David Hendricks has posted comments on this change. ( https://review.coreboot.org/21830 )
Change subject: fixup! Convert flashrom to git
......................................................................
Patch Set 1: Code-Review-1
(2 comments)
Mostly looks good, aside from a couple small issues with the commit message.
As I mentioned in a previous patch, I don't like the long comments. But that's an issue we can resolve another time.
https://review.coreboot.org/#/c/21830/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/21830/1//COMMIT_MSG@7
PS1, Line 7: fixup! Convert flashrom to git
Not a fixup.
https://review.coreboot.org/#/c/21830/1//COMMIT_MSG@10
PS1, Line 10: expend
expand?
-- 
To view, visit https://review.coreboot.org/21830
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: staging
Gerrit-MessageType: comment
Gerrit-Change-Id: I0c66f2508cc754cf9219211a06d6f305a32c422d
Gerrit-Change-Number: 21830
Gerrit-PatchSet: 1
Gerrit-Owner: Stefan Tauner stefan.tauner@gmx.at
Gerrit-Reviewer: David Hendricks david.hendricks@gmail.com
Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Sun, 01 Oct 2017 22:02:23 +0000
Gerrit-HasComments: Yes