Attention is currently required from: Anastasia Klimchuk, Peter Marheine.
Dmitry Zhadinets has posted comments on this change by Dmitry Zhadinets. ( https://review.coreboot.org/c/flashrom/+/86875?usp=email )
Change subject: libflashrom: Update the API for Logger Callback
......................................................................
Patch Set 7:
(1 comment)
File libflashrom.c:
https://review.coreboot.org/c/flashrom/+/86875/comment/e93faea2_acdf524f?usp... :
PS6, Line 84: if (!log_callback && global_log_callback == format_message_and_invoke_log_callback_v2)
: global_log_callback = NULL;
Great review helps finding bugs. This is the case. Thx […]
*The logic of this condition was to reset log callback v**1** only in the case if it was installed by set_v2 op
--
To view, visit
https://review.coreboot.org/c/flashrom/+/86875?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: Iea738bd371fa3d69b9cf222c89ee67490d30af39
Gerrit-Change-Number: 86875
Gerrit-PatchSet: 7
Gerrit-Owner: Dmitry Zhadinets
dzhadinets@gmail.com
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Peter Marheine
pmarheine@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Attention: Peter Marheine
pmarheine@chromium.org
Gerrit-Comment-Date: Wed, 26 Mar 2025 01:11:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Dmitry Zhadinets
dzhadinets@gmail.com
Comment-In-Reply-To: Anastasia Klimchuk
aklm@chromium.org