Attention is currently required from: Anastasia Klimchuk, Fabrice Fontaine, Thomas Heijligen.
Alexander Goncharov has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/78930?usp=email )
Change subject: Makefile: CONFIG_INTERNAL depends on raw mem access ......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1: Thanks for the patch!
Were you able to compile flashrom without errors after applying this patch? Do you need `internal` programmer support in your flashrom build? I'm asking that because I assume that you have compiled flashrom without it.
Makefile [disables all drivers needing raw access](https://review.coreboot.org/plugins/gitiles/flashrom/+/refs/heads/main/Makef...) on `sh` architecture (`build-end.log` says so).
Back in the days when it was added in the commit 8d0d53fdd0 , the code marked `CONFIG_INTERNAL` option as unavailable. Then CB:22671 made compiling the internal programmer available only on x86 or mipsel. And eventually CB:61300 allowed compiling internal programmer for all Linux platforms.
-
Alexander Goncharov (Code Review)