Attention is currently required from: Felix Singer, Nico Huber, Michał Żygowski, Paul Menzel, Angel Pons. Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55715 )
Change subject: tuxedo_ec: Implement support for flashing ECs on TUXEDO laptops ......................................................................
Patch Set 4:
(4 comments)
File tuxedo_ec.c:
https://review.coreboot.org/c/flashrom/+/55715/comment/91b4046b_a4f0aaa5 PS4, Line 2: * This file is part of the flashrom project.
Why? This isn't coreboot.
oops. you're right. thanks
https://review.coreboot.org/c/flashrom/+/55715/comment/8c22e996_5d74a24b PS4, Line 4: * Copyright (C) 2021, TUXEDO Computers GmbH
Why?
oops. you're right. thanks
https://review.coreboot.org/c/flashrom/+/55715/comment/315becee_8742677d PS4, Line 6: * This program is free software; you can redistribute it and/or modify : * it under the terms of the GNU General Public License as published by : * the Free Software Foundation; version 2 of the License. : * : * This program is distributed in the hope that it will be useful, : * but WITHOUT ANY WARRANTY; without even the implied warranty of : * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the : * GNU General Public License for more details. :
Why?
oops. you're right. thanks
https://review.coreboot.org/c/flashrom/+/55715/comment/46b59a5c_adeca3a2 PS4, Line 822: if (strcmp(current_ec_project, new_ec_project)) { : msg_perr("Wrong EC project. This file can't be used on this machine\n"); : return 1; : } : can we add a parameter for forcing here? One might use flashrom to switch from system76 ec to vendor, or from vendor to <whatever>