Attention is currently required from: Anastasia Klimchuk, Peter Marheine.
Dmitry Zhadinets has posted comments on this change by Dmitry Zhadinets. ( https://review.coreboot.org/c/flashrom/+/86875?usp=email )
Change subject: libflashrom: Update the API for Logger Callback ......................................................................
Patch Set 9:
(1 comment)
File libflashrom.c:
https://review.coreboot.org/c/flashrom/+/86875/comment/cd1fad7d_64ad61c1?usp... : PS4, Line 59: /* Dynamic messages and double formatting may not be ideal, : as they are slow. It would be better to limit the message : size to a fixed value (e.g., char message[1024] = {0};). */
Returning an error seems like an okay start, but in practical terms that's nearly the same as silent […]
I did. I agree that truncation is better then nothing but .... If the user will really want to handle long messages he will not be ably to do it. Only recompilation or using the old approach. because the user does not control it.