Change in flashrom[staging]: Free board_vendor and board_model vars before returning - flashrom-gerrit

16 Apr 2017


      Nico Huber has posted comments on this change. ( https://review.coreboot.org/18207 )
Change subject: Free board_vendor and board_model vars before returning
......................................................................
Patch Set 3:
(1 comment)
...
it seems like return 1 is the default except for a few cases. how
about initializing ret = 1, and drop the _1 label?
Not that easy since `ret` might get overwritten in between.
https://review.coreboot.org/#/c/18207/3/internal.c
File internal.c:
Line 163: #if defined __FLASHROM_LITTLE_ENDIAN__
Well, this is a problem... `ret` wouldn't be defined otherwise.
Just remove the guard?
-- 
To view, visit https://review.coreboot.org/18207
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I825f53702803292277b44dcb03fdc49b5dd410a8
Gerrit-PatchSet: 3
Gerrit-Project: flashrom
Gerrit-Branch: staging
Gerrit-Owner: Martin Roth martinroth@google.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Stefan Tauner stefan.tauner@gmx.at
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes