Attention is currently required from: Felix Singer.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/57800 )
Change subject: Remove preprocessor closing comments
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
There was at least one case where I had to ask Gerrit for additional
context to see the matching #if (and my context setting is above the
default already). So there is definitely some value.
Also, I'd much prefer to focus on getting rid of the #if mess.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/57800
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I74288afde108e764adc651039aae81857abffedf
Gerrit-Change-Number: 57800
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Comment-Date: Sun, 26 Sep 2021 16:16:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment