Attention is currently required from: Simon Buhrow, Nico Huber, Edward O'Callaghan, Samir Ibradžić.
Alan Green has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/40477 )
Change subject: ft2232_spi.c: Pack WREN and op in one ftdi_write_data() call
......................................................................
Patch Set 25: Code-Review+1
(2 comments)
Patchset:
PS25:
I'd be happy to see faster programming. Thank you for putting this together. I'm sorry I didn't see it earlier!
If you'd like someone to pick up this change (I see it has been in flight for over a year) let me know.
File ft2232_spi.c:
https://review.coreboot.org/c/flashrom/+/40477/comment/c1a0b99a_3f6b582e
PS25, Line 189: ft2232_spi_send_command
There's much repeated code between send_command and send_multicommand. Can send_command be implemented by calling ft2232_spi_send_multicommand() ?
--
To view, visit
https://review.coreboot.org/c/flashrom/+/40477
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ie4a07499ec5ef0af23818593f45dc427285a9e8a
Gerrit-Change-Number: 40477
Gerrit-PatchSet: 25
Gerrit-Owner: Simon Buhrow
Gerrit-Reviewer: Alan Green
avg@google.com
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Samir Ibradžić
sibradzic@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Patrick Georgi
pgeorgi@google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Simon Buhrow
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Attention: Samir Ibradžić
sibradzic@gmail.com
Gerrit-Comment-Date: Tue, 20 Apr 2021 01:17:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment