Nico Huber has posted comments on this change. ( https://review.coreboot.org/23865 )
Change subject: Fixed mingw detection on Windows 7 (NT-6.1) and hopefully in another non XP Windows build environments too.
......................................................................
Patch Set 1:
Patch Set 1:
(7 comments)
Thank you very much for the review Nico!
Actually tgotic proposed a much simpler (and I think better)
approach for checking the MingW environment:
https://github.com/flashrom/flashrom/pull/33
Is it possible to upload a new patchset if I am not an owner at the
gerrit?
Yes, that works. Generally, you should ask the change's owner first,
but as you are the author anyway in this case, just do it.
--
To view, visit
https://review.coreboot.org/23865
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f856dc4847c4ca9197b1935b7a9b9071b46c70a
Gerrit-Change-Number: 23865
Gerrit-PatchSet: 1
Gerrit-Owner: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Miklós Márton
martonmiklosqdev@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Márton Miklós
martonmiklosqdev@gmail.com
Gerrit-Comment-Date: Wed, 07 Mar 2018 16:12:46 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No