Attention is currently required from: Simon Buhrow, Edward O'Callaghan, Aarya.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/65844 )
Change subject: flashrom.c:Add auxillary functions needed for new erase selction algorithm
......................................................................
Patch Set 78: Code-Review+1
(2 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/65844/comment/d9306e4a_23d73b1d
PS78, Line 7: flashrom.c:Add auxillary functions needed for new erase selction algorithm
This also overflows 72 chars limit
https://review.coreboot.org/c/flashrom/+/65844/comment/3a29f7ed_21a3db8c
PS78, Line 9: 1)Add a function to flatten out the addresses of the flash chip as per the
and this
just check that all commit message is max 72 chars width
--
To view, visit
https://review.coreboot.org/c/flashrom/+/65844
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ic57ca1cca3d1646543f6b5939ba9c35db8d08256
Gerrit-Change-Number: 65844
Gerrit-PatchSet: 78
Gerrit-Owner: Aarya
aarya.chaumal@gmail.com
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Simon Buhrow
Gerrit-Reviewer: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Simon Buhrow
Gerrit-Attention: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Attention: Aarya
aarya.chaumal@gmail.com
Gerrit-Comment-Date: Sun, 15 Jan 2023 10:41:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment