Change in flashrom[master]: ich_descriptors.c: Ensure unsigned types >=0 on to prevent underflow ...
Attention is currently required from: Angel Pons, Light, Anastasia Klimchuk. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62764 )
Change subject: ich_descriptors.c: Ensure unsigned types >=0 on to prevent underflow error ......................................................................
Patch Set 14: Code-Review+1
(2 comments)
File ich_descriptors.c:
https://review.coreboot.org/c/flashrom/+/62764/comment/f097a859_1613cb06 PS6, Line 507: assert(j >= 12);
Oh yes, sorry that's all good, I missed! I am marking this as resolved then?
Ack
File ich_descriptors.c:
https://review.coreboot.org/c/flashrom/+/62764/comment/46622ef5_3c079b6c PS12, Line 505: ++j
Done
Sorry, my bad, I put the `++j` in a comment (it feels more natural to me).
-
Nico Huber (Code Review)