Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/69518 )
Change subject: linux_mtd: Mark Opaque chip as tested for WP ......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/flashrom/+/69518/comment/075da238_fe4ef79a PS2, Line 9: Since linux_mtd supports write-protect, its probe function needs Yes, I spent some time thinking about this, before producing this patch and CB:69842.
What happens if the chip doesn't support write-protect?
Not entirely sure, I will check. But I don't see programmer code ever returning errors like "wp unsuported". Perhaps this is handled at a different level, or maybe everything that goes through linux_mtd can support wp. The programmer (and all the other opaque master) do not check whether any of the operations are supported. They just set the chip as "everything tested". I guess, by design of opaque masters?
So this is why I made CB:69842 too. Similar motivation, although I made a different commit message for CB:69842 , to be very specific.
In any case, showing to the user "your Opaque chip is not tested, please report on the mailing list" is not much help: what do they report, "Opaque chip"? My understanding this is also by design, that users do not [need to] know which exacty chip that is.
-
Anastasia Klimchuk (Code Review)