Edward O'Callaghan has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/61582 )
Change subject: cli_classic.: Use flashrom_init() from API ......................................................................
cli_classic.: Use flashrom_init() from API
flashrom_init() already does delay calibration and self-checking via the canonical libflashrom API. Port the cli implementation to go via the libflashrom API entry-point natively.
BUG=none TEST=`make`
Change-Id: I07faeed876f678c35355621a080c7852eed16824 Signed-off-by: Edward O'Callaghan quasisec@google.com --- M cli_classic.c 1 file changed, 2 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/82/61582/1
diff --git a/cli_classic.c b/cli_classic.c index 8c337eb..fe1eeea 100644 --- a/cli_classic.c +++ b/cli_classic.c @@ -350,7 +350,8 @@ print_version(); print_banner();
- if (selfcheck()) + /* FIXME: Delay calibration should happen in programmer code. */ + if (flashrom_init(1)) exit(1);
setbuf(stdout, NULL); @@ -661,9 +662,6 @@ } }
- /* FIXME: Delay calibration should happen in programmer code. */ - myusec_calibrate_delay(); - if (programmer_init(prog, pparam)) { msg_perr("Error: Programmer initialization failed.\n"); ret = 1;