[S] Change in flashrom[main]: erasure_layout: Fix double invocation of erasers - flashrom-gerrit

20 Oct 2023


      Attention is currently required from: Aarya, Alexander Goncharov, Anastasia Klimchuk, Sam McNally.
Peter Marheine has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/77747?usp=email )
Change subject: erasure_layout: Fix double invocation of erasers
......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS2:
...
I did some more investigation and traced when this double-erase started: […]
I agree that the new condition seems unnecessary, since it duplicates the loop's termination condition and we know the loop terminates. The block at line 245 should simply be deleted.
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/77747?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I92351eba0fd29114ce98b4a839358e92d176af28
Gerrit-Change-Number: 77747
Gerrit-PatchSet: 4
Gerrit-Owner: Anastasia Klimchuk aklm@chromium.org
Gerrit-Reviewer: Aarya aarya.chaumal@gmail.com
Gerrit-Reviewer: Alexander Goncharov chat@joursoir.net
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Sam McNally sammc@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Peter Marheine pmarheine@chromium.org
Gerrit-CC: Stefan Reinauer stefan.reinauer@coreboot.org
Gerrit-Attention: Sam McNally sammc@google.com
Gerrit-Attention: Aarya aarya.chaumal@gmail.com
Gerrit-Attention: Anastasia Klimchuk aklm@chromium.org
Gerrit-Attention: Alexander Goncharov chat@joursoir.net
Gerrit-Comment-Date: Fri, 20 Oct 2023 04:59:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Aarya aarya.chaumal@gmail.com
Comment-In-Reply-To: Anastasia Klimchuk aklm@chromium.org
Gerrit-MessageType: comment