Attention is currently required from: Angel Pons.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/52470 )
Change subject: hwaccess.c: Fix PowerPC memory barrier
......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS4:
What part of this is hard to predict?
If it will compile. We are outside of ISO C here. The weirdest part:
ISO C lists `asm` as a common extension, however, if you enable strict
ISO C conformance (which another patch tried), the `asm` keyword
doesn't exist anymore because it's a valid identifier in C (strictly
speaking).
We don't know what compiler (version) will be used. As I said above, we
can raise the bar but I think we should only do it after the release.
Isn't this fixing a compilation error (specifically guarded with IS_PPC)
It is. But fixing things for one compiler/case can break them for another.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/52470
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ia84fd1362a1d39aca6269eef22ac994dee68ba4b
Gerrit-Change-Number: 52470
Gerrit-PatchSet: 4
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Sat, 10 Jul 2021 11:00:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Stefan Reinauer
stefan.reinauer@coreboot.org
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment