Change in flashrom[master]: linux_mtd: Free param right after its last usage - flashrom-gerrit

5 Aug 2021


      Attention is currently required from: Nico Huber, Edward O'Callaghan, Anastasia Klimchuk.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/56822 )
Change subject: linux_mtd: Free param right after its last usage
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
File linux_mtd.c:
https://review.coreboot.org/c/flashrom/+/56822/comment/4a96e689_b4c8808b 
PS1, Line 401: if (param)
             : 			msg_perr("%s does not exist\n", sysfs_path);
             : 		else
             : 			msg_pdbg("%s does not exist\n", sysfs_path);
suspicious, both branches are equal?
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/56822
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I126a8d06297ef4d42bc93a73f7067ccc1352d1e9
Gerrit-Change-Number: 56822
Gerrit-PatchSet: 1
Gerrit-Owner: Anastasia Klimchuk aklm@chromium.org
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Nico Huber nico.h@gmx.de
Gerrit-Attention: Edward O'Callaghan quasisec@chromium.org
Gerrit-Attention: Anastasia Klimchuk aklm@chromium.org
Gerrit-Comment-Date: Thu, 05 Aug 2021 14:35:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment