Attention is currently required from: Angel Pons, Peter Marheine.
Anastasia Klimchuk has posted comments on this change by Angel Pons. ( https://review.coreboot.org/c/flashrom/+/83307?usp=email )
Change subject: flashchips: Splitting flashchips into separate files by vendor
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
At current state, the output of `flashrom -L` is identical before / after the patch. […]
I forgot about docs! Tried again, with docs and manpage disabled like this:
`meson configure -Ddocumentation=disabled -Dman-pages=disabled`
and also in line 61 of meson.build, changed the version to be "none"
Now binaries are the same with and without the patch!
(Maybe there is more elegant way of ignoring version, other then modifying line 61, but I only came up with this hack)
--
To view, visit
https://review.coreboot.org/c/flashrom/+/83307?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I3a9ebb0575e2700c5871d16875495d9c8943b30b
Gerrit-Change-Number: 83307
Gerrit-PatchSet: 2
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Nikolai Artemiev
nartemiev@google.com
Gerrit-Reviewer: Peter Marheine
pmarheine@chromium.org
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Peter Marheine
pmarheine@chromium.org
Gerrit-Comment-Date: Sun, 24 Nov 2024 22:26:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Anastasia Klimchuk
aklm@chromium.org