Attention is currently required from: Thomas Heijligen, Edward O'Callaghan, Nikolai Artemiev, Peter Marheine.
Jonathon Hall has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67695 )
Change subject: drivers: Move (un)map_flash_region from programmer to par_master
......................................................................
Patch Set 4:
(2 comments)
Patchset:
PS3:
I've some WIP patches for atavia and atapromise. […]
This patch will supersede CB:67655, but I'll leave CB:67656 separate since it isn't so trivial (unless you would rather I merge it into this patch).
File serprog.c:
https://review.coreboot.org/c/flashrom/+/67695/comment/823dfc3b_9fb5d96a
PS2, Line 582: .map_flash_region = serprog_map,
This is a hack to make sure the chips have a max size of 16MB. […]
Ah I see it now, I replaced the mapper with max_rom_decode for all bus types.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/67695
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I9c3df6ae260bcdb246dfb0cd8e043919609b014b
Gerrit-Change-Number: 67695
Gerrit-PatchSet: 4
Gerrit-Owner: Jonathon Hall
jonathon.hall@puri.sm
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Nikolai Artemiev
nartemiev@google.com
Gerrit-Reviewer: Peter Marheine
pmarheine@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Thomas Heijligen
src@posteo.de
Gerrit-Attention: Thomas Heijligen
src@posteo.de
Gerrit-Attention: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Attention: Nikolai Artemiev
nartemiev@google.com
Gerrit-Attention: Peter Marheine
pmarheine@chromium.org
Gerrit-Comment-Date: Tue, 20 Sep 2022 18:19:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Thomas Heijligen
src@posteo.de
Comment-In-Reply-To: Jonathon Hall
jonathon.hall@puri.sm
Gerrit-MessageType: comment