Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons, Nikolai Artemiev. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62643 )
Change subject: writeprotect.c: refactor and fix wp_mode functions ......................................................................
Patch Set 2: Code-Review+1
(2 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/62643/comment/dc75ddae_a400ebb4 PS2, Line 11: Given that is a follow up on previous patch, let's maybe add a reference. It would be easier to understand where this comes from. So you can say:
This is a follow up on commit 12dbc4e04508aecfff53ad95b6f68865da1b4f07
Gerrit will add a link to a patch, which is very convenient.
https://review.coreboot.org/c/flashrom/+/62643/comment/94248bf6_cf61eb49 PS2, Line 16: builds It might be fine, but just in case, maybe you have an environment with this patch already and you can run once?
-
Anastasia Klimchuk (Code Review)