Hello build bot (Jenkins),
I'd like you to do a code review. Please visit
https://review.coreboot.org/22333
to review the following change.
Change subject: Fix ID of ST M25P05 ......................................................................
Fix ID of ST M25P05
The (old) ST (now Micron) M25P05 does only support RES for identification. Unfortunately, the vendor datasheet states the same ID as for the M25P10 (0x10) and thus flashrom has treated these two as evil twins in the past. However, real hardware confirmed that the real ID of this chip is 0x05.
Change-Id: Idc75f8cb98e7ef0c47c4527cedcc4da3723bd779 Signed-off-by: Serge Vasilugin vasilugin@yandex.ru Tested-by: Serge Vasilugin vasilugin@yandex.ru Reviewed-on: https://review.coreboot.org/21920 Reviewed-by: Nico Huber nico.h@gmx.de Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M flashchips.h 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/33/22333/1
diff --git a/flashchips.h b/flashchips.h index 28a155d..15574bb 100644 --- a/flashchips.h +++ b/flashchips.h @@ -748,9 +748,9 @@ */ #define ST_ID 0x20 /* ST / SGS/Thomson / Numonyx (later acquired by Micron) */ #define ST_M25P05A 0x2010 -#define ST_M25P05_RES 0x10 /* Same code as M25P10. */ +#define ST_M25P05_RES 0x05 #define ST_M25P10A 0x2011 -#define ST_M25P10_RES 0x10 /* Same code as M25P05. */ +#define ST_M25P10_RES 0x10 #define ST_M25P20 0x2012 #define ST_M25P20_RES 0x11 #define ST_M25P40 0x2013