Attention is currently required from: Nico Huber, Angel Pons, Michael Niewöhner. Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55714 )
Change subject: acpi_ec: Implement basic ACPI embedded controller API ......................................................................
Patch Set 4:
(3 comments)
File acpi_ec.h:
https://review.coreboot.org/c/flashrom/+/55714/comment/5691775f_2466deb9 PS4, Line 41: bool ec_wait_for_ibuf(uint8_t control_port, unsigned int max_checks); : bool ec_wait_for_obuf(uint8_t control_port, unsigned int max_checks);
Do these need to be exported?
Actually they don't
https://review.coreboot.org/c/flashrom/+/55714/comment/5ee6f636_1587b041 PS4, Line 44: bool ec_write_cmd(uint8_t control_port, uint8_t cmd, unsigned int max_checks); : bool ec_read_byte(uint8_t control_port, uint8_t data_port, uint8_t *data, : unsigned int max_checks); : bool ec_write_byte(uint8_t control_port, uint8_t data_port, uint8_t data, : unsigned int max_checks); :
If these are part of an `acpi_ec` API and ACPI standardized the ports, […]
The EFI firmware update application talks through multiple port pairs. I have no idea why it is implemented that way. Given the quality of this EFI application which the patches are based on, it may even simply be a bug.
File acpi_ec.c:
https://review.coreboot.org/c/flashrom/+/55714/comment/7d5e9f95_bcb1acbd PS4, Line 23: ontrol_port
cmd_port
Rather status port
-
Michał Żygowski (Code Review)