Attention is currently required from: Edward O'Callaghan, Angel Pons, Neill Corlett. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/61288 )
Change subject: Add mediatek_i2c_spi interface. ......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1: Hi Neill, thanks for your patch.
I've some questions ahead of review: * The basic SPI command interface looks a lot like the one of the mstarddc_spi driver. Have you looked into that? maybe there can be some code shared. * There are two implementations to use either I2C or SMBus transfers. Are both paths tested? I only gave it a short glimpse, but it looked like the SMBus path would be doing something different. * There are some hard-coded GPIO numbers. Is this a reference design or maybe specific to a particular board?
-
Nico Huber (Code Review)