Attention is currently required from: Peter Marheine.
Anastasia Klimchuk has posted comments on this change by Anastasia Klimchuk. ( https://review.coreboot.org/c/flashrom/+/85292?usp=email )
Change subject: libflashrom: Fix comparison of layout romentry regions ......................................................................
Patch Set 1:
(1 comment)
File libflashrom.c:
https://review.coreboot.org/c/flashrom/+/85292/comment/6f73d737_d7317e88?usp... : PS1, Line 309: static int compare_region_with_dump(const struct romentry *const a, const struct romentry *const b) I am wondering whether `read_prot` and `write_prot` should be here. There are not filled in from dump, but that means they will have default values, and always the same? (so, won't make an effect on comparison).