Attention is currently required from: Anton Samsonov, Thomas Heijligen.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/77089?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: Remove dependency on C23 __has_include()
......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS4:
Sorry for such a long delay in response, but finally I got back to this patch, and wow it looks so much better, thank you! :)
I only want to ask add testing info in commit message. I understand you have tested both makefile and meson, but better have the info in commit message. Also if you have tested on different environments (with or without headers), you can list environments that you tested on.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/77089?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: Ic544963ffd29626ae0a21bdddb1c78850cc43ec6
Gerrit-Change-Number: 77089
Gerrit-PatchSet: 4
Gerrit-Owner: Anton Samsonov
devel@zxlab.ru
Gerrit-Reviewer: Alexander Goncharov
chat@joursoir.net
Gerrit-Reviewer: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Anastasia Klimchuk
aklm@chromium.org
Gerrit-CC: Anton Samsonov
avscomputing@gmail.com
Gerrit-CC: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Thomas Heijligen
src@posteo.de
Gerrit-Attention: Anton Samsonov
devel@zxlab.ru
Gerrit-Comment-Date: Fri, 17 Nov 2023 10:05:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment