Attention is currently required from: Eric Park, Nikolai Artemiev, Stefan Reinauer.
Anastasia Klimchuk has posted comments on this change by Eric Park. ( https://review.coreboot.org/c/flashrom/+/86990?usp=email )
Change subject: flashchips: Add XMC XM25QH64A ......................................................................
Patch Set 6:
(4 comments)
Patchset:
PS1:
Sorry this took so long. […]
Thanks so much for testing, I appreciate it. WP is write protection, but it's fine to add initial support without WP.
Patchset:
PS4:
Thank you for the comments! I've modified the commit with the changes. […]
Great work! I have two last small comments and that should be it :)
Commit Message:
https://review.coreboot.org/c/flashrom/+/86990/comment/7963c326_88ddcd01?usp... : PS6, Line 14: I forgot to ask: would you please add link to datasheet in commit message? I found one at https://www.micros.com.pl/mediaserver/PFXM25QH64AHIG_0001.pdf but if you have other public link it's fine too.
File flashchips/xmc.c:
https://review.coreboot.org/c/flashrom/+/86990/comment/0b0c1b85_599838c2?usp... : PS6, Line 337: TEST_OK_PREW Based on what you explained in the other comment (about testing), the test status should be `TEST_OK_PR` (which means tested Probe and Reading). E is erase, W is write, B is WP or write-protection, but as I understand you were not performing those operations.
It's fine to have chip partially tested: if later someone does erase/write successfully, test status will be updated.
-
Anastasia Klimchuk (Code Review)