Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons, Anastasia Klimchuk, Nikolai Artemiev. Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62768 )
Change subject: flashrom.8.tmpl: Add raiden_debug_spi doc entry ......................................................................
Patch Set 1:
(3 comments)
File flashrom.8.tmpl:
https://review.coreboot.org/c/flashrom/+/62768/comment/e9abd0f8_6ae729e3 PS1, Line 319: Currently supported are
This is of course not for this patch, but is there any reason programmers are not in alphabetical or […]
I was thinking the same thing. Both here and in the flashrom list itself.
https://review.coreboot.org/c/flashrom/+/62768/comment/3d8f208e_386a6e1a PS1, Line 361: .BR "* raiden_debug_spi" " (for SPI flash ROMs attached to a ChromiumOS servo debug board)"
ft2232_spi also works with Servo. I guess it's about the version? Also, […]
Servo V2 (and maybe V3, which I think is completely obsolete now) uses the FTDI code. For some firmware engineers, the servo V2 is still the preferred flashing method because it's significantly faster than any of the debug tools using the Raiden driver.
SuzyQable, Servo V4, uServo, and C2D2 debug tools all use the Raiden driver as they're all based on the Chrome EC codebase in one way or another.
Maybe: "* raiden_debug_spi" " (For Chrome EC based debug tools - SuzyQable, Servo V4, C2D2 & uServo)
https://review.coreboot.org/c/flashrom/+/62768/comment/2d24c299_1159d7a7 PS1, Line 1143: servo serial to use Clarify whether this is by the serial number of the board or a uart: /dev/tty
Add instructions on how to figure out which servo is which.
-
Martin Roth (Code Review)