Attention is currently required from: Anton Samsonov, Anton Samsonov, Thomas Heijligen.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/79152?usp=email )
Change subject: Abandon (Unable to trick Jenkins to re-check after adding Signed-off-by) Change-Id: I8694e618878823a9e96b1f2bcfa63f6c71d3c2ed
......................................................................
Patch Set 3:
(2 comments)
Patchset:
PS3:
To have Jenkins re-check, you can change something in the code.
File Makefile:
https://review.coreboot.org/c/flashrom/+/79152/comment/f8be7cd3_d39869f5 :
PS2, Line 395: ifneq ($(VERSION_GIT),)
Does this work properly when `VERSION_GIT` is not defined? […]
Ack
--
To view, visit
https://review.coreboot.org/c/flashrom/+/79152?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I8694e618878823a9e96b1f2bcfa63f6c71d3c2ed
Gerrit-Change-Number: 79152
Gerrit-PatchSet: 3
Gerrit-Owner: Anton Samsonov
devel@zxlab.ru
Gerrit-Reviewer: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Anton Samsonov
contact-launchpad@zxlab.ru
Gerrit-Attention: Thomas Heijligen
src@posteo.de
Gerrit-Attention: Anton Samsonov
devel@zxlab.ru
Gerrit-Attention: Anton Samsonov
contact-launchpad@zxlab.ru
Gerrit-Comment-Date: Tue, 21 Nov 2023 12:27:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Anton Samsonov
contact-launchpad@zxlab.ru
Gerrit-MessageType: comment