Attention is currently required from: Nico Huber, Angel Pons, Sergii Dmytruk. Nikolai Artemiev has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58480 )
Change subject: flashchips,writeprotect_ranges: add range decoding function ......................................................................
Patch Set 38:
(3 comments)
File flash.h:
https://review.coreboot.org/c/flashrom/+/58480/comment/ca09ff7f_c41ee705 PS35, Line 311: size_t *start, size_t *len
Should we put output parameters first?
Done
File writeprotect_ranges.c:
https://review.coreboot.org/c/flashrom/+/58480/comment/1e3d3436_6cb89e43 PS35, Line 8: * the Free Software Foundation; version 2 of the License.
Can we have v2+?
Done
https://review.coreboot.org/c/flashrom/+/58480/comment/fc9f76f6_1ac772bc PS35, Line 23: * various chips is more fully known.
I guess this would be something that's never 100% finished. Maybe not […]
Good point, I've dropped the comment; I don't think we'll find a significantly better name than _spi25 anyway.
-
Nikolai Artemiev (Code Review)