Attention is currently required from: Felix Singer, Nico Huber, Edward O'Callaghan, Angel Pons, Anastasia Klimchuk, Nikolai Artemiev, Nicholas Chin. Hello build bot (Jenkins), Nico Huber, Edward O'Callaghan, Angel Pons, Nikolai Artemiev, Nicholas Chin,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/58735
to look at the new patch set (#9).
Change subject: ichspi: Split very long init function into two ......................................................................
ichspi: Split very long init function into two
ich_init_spi is very long, but logically it can be split. Init function detects the chipset and then the rest of operations depends on the chipset.
Init function is more readable now, it consists of only a switch.
Initialisation of hwseq and swseq that used to happen in the beginning of init function now moved to init_ich_default, because hwseq and swseq are only used for chipsets served by init_ich_default.
BUG=b:204488958 TEST=Check that the following scenarios still behave properly: 1) probe-read-verify-erase section-write-reboot on Intel octopus board with GD25LQ128C/GD25LQ128D/GD25LQ128E 2) probe and read on Panther Point (7 series PCH) 3) on machine with ich7 chipset, output from probe and read is the same between master and this patch
Change-Id: I6789bc456a4878e6555831ae0b80ecbdbf62938b Signed-off-by: Anastasia Klimchuk aklm@chromium.org Tested-by: Anastasia Klimchuk aklm@chromium.org Tested-by: Nico Huber nico.h@gmx.de Tested-by: Nicholas Chin nic.c3.14@gmail.com Signed-off-by: Anastasia Klimchuk aklm@chromium.org --- M ichspi.c 1 file changed, 271 insertions(+), 258 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/35/58735/9