Attention is currently required from: Alexandru Stan, Nikolai Artemiev, Stefan Reinauer.
Anastasia Klimchuk has posted comments on this change by Alexandru Stan. ( https://review.coreboot.org/c/flashrom/+/84752?usp=email )
Change subject: flashchips: add Winbond W25R512NW / W74M51NW ......................................................................
Patch Set 2:
(3 comments)
File flashchips.c:
https://review.coreboot.org/c/flashrom/+/84752/comment/4ff7045d_42bc76c9?usp... : PS1, Line 20271: 1650
What the datasheet says? I would say, voltage you better just copy from datasheet
ah, but you already updated the voltage according to datasheet. I am resolving this.
File flashchips.c:
https://review.coreboot.org/c/flashrom/+/84752/comment/d67c813b_4d2c36c1?usp... : PS2, Line 20239: 1024B total, 256B reserved Maybe the better comment is what's in the datasheet:
3X256-Bytes Security Registers with OTP locks
and then the rest of the comment as it is, with opcodes.
Or as I said you can remove the comment line.
https://review.coreboot.org/c/flashrom/+/84752/comment/58908027_b4550506?usp... : PS2, Line 20269: .printlock = SPI_PRETTYPRINT_STATUS_REGISTER_BP3_SRWD, : .unlock = SPI_DISABLE_BLOCKPROTECT, :
Since you haven't tested write-protection and not marking it as tested, you can put here […]
Actually, from the datasheet this is fine, leave it. And yes, you are not marking it as tested anyway.