Attention is currently required from: Hsuan-ting Chen, Stefan Reinauer.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/81356?usp=email )
Change subject: ich: Add names for region 5, 9, 10, 11, 12, 15 ......................................................................
Patch Set 5:
(2 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/81356/comment/b5df598a_c72a291b : PS1, Line 12: * Incorporate missing region names from https://github.com/coreboot/coreboot/blob/main/util/ifdtool/ifdtool.c for completeness.
I believe there should be a document with its name like 'MTL SPI Programming Guide,' but I don't thi […]
Just wanted to follow up on this, since the patch is waiting for a while. I have checked that naming aligns with coreboot code, but that's as much as I can do.
My interest to read docs goes beyond this patch, I would like to build more knowledge on ich. I heard about the infamous situation with lots of open-source code based on non-public docs :(
At the very least, is this testable by for example printing the descriptors for specific models?
File util/ich_descriptors_tool/ich_descriptors_tool.c:
https://review.coreboot.org/c/flashrom/+/81356/comment/08659379_5ecc8379 : PS5, Line 42: 10GbE0 This one occurrence that I noticed when the new name is different from the old one. Everywhere else "unknown" is replaced with new name, but the old existing name is not changed.
Is this intentional? Does it matter?
-
Anastasia Klimchuk (Code Review)