Edward O'Callaghan has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/35793 )
Change subject: cli_classic: Fix first line of --help to match manpage ......................................................................
cli_classic: Fix first line of --help to match manpage
Make the first line of --help in usage to align with the format of the man page, including fixing any missing options.
Change-Id: I44f82c6a54fddb54bf268fe6eb22e50acb6025cf Signed-off-by: Edward O'Callaghan quasisec@chromium.org --- M cli_classic.c 1 file changed, 6 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/93/35793/1
diff --git a/cli_classic.c b/cli_classic.c index 6c3c9da..1c289a7 100644 --- a/cli_classic.c +++ b/cli_classic.c @@ -35,9 +35,12 @@ #if CONFIG_PRINT_WIKI == 1 "-z|" #endif - "-p <programmername>[:<parameters>] [-c <chipname>]\n" - "[-E|(-r|-w|-v) <file>] [(-l <layoutfile>|--ifd) [-i <imagename>]...] [-n] [-N] [-f]]\n" - "[-V[V[V]]] [-o <logfile>]\n\n", name); + "\n\t-p <programmername>[:<parameters>] [-c <chipname>]\n" + "\t\t(--flash-name|--flash-size|\n" + "\t\t[-E|(-r|-w|-v) <file>]\n" + "\t\t[(-l <layoutfile>|--ifd| --fmap|--fmap-file <file>) [-i <imagename>]...]\n" + "\t\t[-n] [-N] [-f])]\n" + "\t[-V[V[V]]] [-o <logfile>]\n\n", name);
printf(" -h | --help print this help text\n" " -R | --version print version (release)\n"
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/35793 )
Change subject: cli_classic: Fix first line of --help to match manpage ......................................................................
Patch Set 3: Code-Review+1
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/35793 )
Change subject: cli_classic: Fix first line of --help to match manpage ......................................................................
Patch Set 3: Code-Review+2
(1 comment)
https://review.coreboot.org/c/flashrom/+/35793/3/cli_classic.c File cli_classic.c:
https://review.coreboot.org/c/flashrom/+/35793/3/cli_classic.c@40 PS3, Line 40: "\t\t[-E|(-r|-w|-v) <file>]\n" : "\t\t[(-l <layoutfile>|--ifd| --fmap|--fmap-file <file>) [-i <imagename>]...]\n" : "\t\t[-n] [-N] [-f])]\n" Nit, these three lines are within the opening parenthesis the line above. Shouldn't this have an additional tab? or a space maybe, to align with the (.
Hello Angel Pons, Stefan Reinauer, build bot (Jenkins), Nico Huber,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/35793
to look at the new patch set (#4).
Change subject: cli_classic: Fix first line of --help to match manpage ......................................................................
cli_classic: Fix first line of --help to match manpage
Make the first line of --help in usage to align with the format of the man page, including fixing any missing options.
V.2: Add an extra space.
Change-Id: I44f82c6a54fddb54bf268fe6eb22e50acb6025cf Signed-off-by: Edward O'Callaghan quasisec@chromium.org --- M cli_classic.c 1 file changed, 6 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/93/35793/4
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/35793 )
Change subject: cli_classic: Fix first line of --help to match manpage ......................................................................
Patch Set 4: Code-Review+2
Patch Set 3: Code-Review+2
(1 comment)
Done. Carrying +2 forward.
Edward O'Callaghan has submitted this change. ( https://review.coreboot.org/c/flashrom/+/35793 )
Change subject: cli_classic: Fix first line of --help to match manpage ......................................................................
cli_classic: Fix first line of --help to match manpage
Make the first line of --help in usage to align with the format of the man page, including fixing any missing options.
V.2: Add an extra space.
Change-Id: I44f82c6a54fddb54bf268fe6eb22e50acb6025cf Signed-off-by: Edward O'Callaghan quasisec@chromium.org Reviewed-on: https://review.coreboot.org/c/flashrom/+/35793 Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M cli_classic.c 1 file changed, 6 insertions(+), 3 deletions(-)
Approvals: build bot (Jenkins): Verified Edward O'Callaghan: Looks good to me, approved
diff --git a/cli_classic.c b/cli_classic.c index 4844d1d..de6ce04 100644 --- a/cli_classic.c +++ b/cli_classic.c @@ -35,9 +35,12 @@ #if CONFIG_PRINT_WIKI == 1 "-z|" #endif - "-p <programmername>[:<parameters>] [-c <chipname>]\n" - "[-E|(-r|-w|-v) <file>] [(-l <layoutfile>|--ifd) [-i <imagename>]...] [-n] [-N] [-f]]\n" - "[-V[V[V]]] [-o <logfile>]\n\n", name); + "\n\t-p <programmername>[:<parameters>] [-c <chipname>]\n" + "\t\t(--flash-name|--flash-size|\n" + "\t\t [-E|(-r|-w|-v) <file>]\n" + "\t\t [(-l <layoutfile>|--ifd| --fmap|--fmap-file <file>) [-i <imagename>]...]\n" + "\t\t [-n] [-N] [-f])]\n" + "\t[-V[V[V]]] [-o <logfile>]\n\n", name);
printf(" -h | --help print this help text\n" " -R | --version print version (release)\n"
-
Angel Pons (Code Review) -
Edward O'Callaghan (Code Review)
-
Nico Huber (Code Review)