Attention is currently required from: Angel Pons, Nico Huber, Sergii Dmytruk.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/60224?usp=email )
Change subject: dummyflasher: make RO status of SPI_SR_WEL explicit
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Sergii, I found this old patch and I am not sure it's needed anymore, because the code has changed a lot since then.
The only thing that might be need is test, although if yes it should go to a different file, `chip_wp.c` with other wp tests.
If you think this patch is not needed anymore, them maybe mark it abandoned.
Also while I was looking at the current code in the dummyflasher I made another patch CB:79390 maybe you can have a look.
Thank you!
--
To view, visit
https://review.coreboot.org/c/flashrom/+/60224?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I5dce77e22a1f9cd29f40ec0881d2b1238a985e97
Gerrit-Change-Number: 60224
Gerrit-PatchSet: 1
Gerrit-Owner: Sergii Dmytruk
sergii.dmytruk@3mdeb.com
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Sergii Dmytruk
sergii.dmytruk@3mdeb.com
Gerrit-Comment-Date: Sun, 03 Dec 2023 09:19:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment