[S] Change in flashrom[master]: cli_classic.c: Early init of layout obscures invalid memory access - flashrom-gerrit

20 Sep 2022


      Attention is currently required from: Edward O'Callaghan, Nikolai Artemiev.
Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67723 )
Change subject: cli_classic.c: Early init of layout obscures invalid memory access
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/flashrom/+/67723/comment/b0a4558f_2d21dc1e 
PS2, Line 7: cli_classic.c: Early init of layout obscures invalid memory access
Can you give the codepath for the invalid memory access and why the patch helps to fix this?
IMO settings flashrom_layout only when some valid layout is found is a good behavior.
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/67723
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I3df61b873da27f6945d60916a1c3713dedfc3924
Gerrit-Change-Number: 67723
Gerrit-PatchSet: 2
Gerrit-Owner: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Nikolai Artemiev nartemiev@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Thomas Heijligen src@posteo.de
Gerrit-Attention: Edward O'Callaghan quasisec@chromium.org
Gerrit-Attention: Nikolai Artemiev nartemiev@google.com
Gerrit-Comment-Date: Tue, 20 Sep 2022 12:28:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment