Shiyu Sun has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/49786 )
Change subject: realtek_mst_i2c_spi.c: Skip return value check for reset function ......................................................................
realtek_mst_i2c_spi.c: Skip return value check for reset function
The return value for reset function can not be guaranteed when reset success. There is no way to check if reset success or not.
BUG=b:147402710,b:152558985 BRANCH=none TEST=builds
Signed-off-by: Shiyu Sun sshiyu@chromium.org Change-Id: Ia6200f7150db4368c26d8dfe779a9e85184b1b06 --- M realtek_mst_i2c_spi.c 1 file changed, 5 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/86/49786/1
diff --git a/realtek_mst_i2c_spi.c b/realtek_mst_i2c_spi.c index e9d6a58..c2bf2b0 100644 --- a/realtek_mst_i2c_spi.c +++ b/realtek_mst_i2c_spi.c @@ -428,9 +428,11 @@ int fd = realtek_mst_data->fd; ret |= realtek_mst_i2c_spi_toggle_gpio_88_strap(fd, false); if (realtek_mst_data->reset) { - ret |= realtek_mst_i2c_spi_reset_mpu(fd); - if (ret != 0) - msg_perr("%s: MCU failed to reset on tear-down.\n", __func__); + /* Return value for reset mpu is not checked since + * the return value is not guaranteed to be 0 on a + * success reset. Currently there is no way to fix that. + * For more details see b:147402710. */ + realtek_mst_i2c_spi_reset_mpu(fd); } i2c_close(fd); free(data);