Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/40275 )
Change subject: flashchips: support for Winbond W25Q64JW ......................................................................
Patch Set 8:
(1 comment)
Patch Set 8:
Patch Set 8:
Patch Set 5: Code-Review+1
(1 comment)
Looks good, thank you! One small nit in the commit message, though.
Note that flashrom loses the "Verified" score when editing the commit message. To make Jenkins run again, you can trigger a rebase (there's a button on Gerrit, around the top right corner).
When I triggered a rebase, it showed "Could not perform action: Change is already up to date.". Is that correct?
That's fine, I fixed the missing Verified.
I'd still prefer to have Jenkins build-test it, just in case. BTW, this would not be an issue with CB:39640
https://review.coreboot.org/c/flashrom/+/40275/8//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/flashrom/+/40275/8//COMMIT_MSG@7 PS8, Line 7: support Um, this is still the same though :S
-
Angel Pons (Code Review)