Attention is currently required from: Nico Huber, Paul Menzel. Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55578 )
Change subject: Add Tiger Lake U Premium support ......................................................................
Patch Set 6:
(3 comments)
File chipset_enable.c:
https://review.coreboot.org/c/flashrom/+/55578/comment/9a90a204_06994483 PS3, Line 659: { "eSPI", BUS_LPC | BUS_FWH } };
No, it shouldn't. We use these flags to decide which chips to probe […]
Added BUS_ESPI enum and removed LPC/FWH. Will that be okay?
File ich_descriptors.c:
https://review.coreboot.org/c/flashrom/+/55578/comment/bee731fd_9e5ca6c2 PS5, Line 278: return "reserved";
I'd suggest "unknown" if we don't want to add a table above. Note, that […]
Added a separate function that will print either read frequency or EC/eSPI frequency for CNL/CML (based on SPI programming guide). Tiger Point has this field reserved and will return unknown
https://review.coreboot.org/c/flashrom/+/55578/comment/8e47fd2b_e98c032f PS5, Line 967: return CHIPSET_500_SERIES_TIGER_POINT;
As suggested somewhere else, I would make this the new fall-back, i.e. […]
Added a new enum for the new fields and used it in the condition
-
Michał Żygowski (Code Review)