Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/30154 )
Change subject: libflashrom.h: Remove line breaks in function signatures ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/30154/1/libflashrom.h File libflashrom.h:
https://review.coreboot.org/#/c/30154/1/libflashrom.h@66 PS1, Line 66: int flashrom_layout_read_fmap_from_rom(struct flashrom_layout **, struct flashrom_flashctx *, off_t offset, size_t length);
Doesn't this exceed the length limit now? (Heck, did we ever write down a length limit in a wiki som […]
I couldn't find anything in the wiki either. Not buried too deep for my memory, though :) (scroll down to the second last hunk) https://mail.coreboot.org/pipermail/flashrom/2012-June/009388.html
I don't know when the discussion took place. Must have been shortly before I started working on coreboot/flashrom.
-
Nico Huber (Code Review)