Attention is currently required from: Nikolai Artemiev, Ssunk, Stefan Reinauer.
Anastasia Klimchuk has posted comments on this change by Ssunk. ( https://review.coreboot.org/c/flashrom/+/83180?usp=email )
Change subject: Add Support for XMC XM25QU80B ......................................................................
Patch Set 1:
(4 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/83180/comment/c8ca6629_3bf54fbe?usp... : PS1, Line 6: : Add Support for XMC XM25QU80B Prefix with `flashchips: ` so that it's easier to go through the list of commits. So your commit title will be:
flashchips: Add Support for XMC XM25QU80B
https://review.coreboot.org/c/flashrom/+/83180/comment/8a8fb6a4_40f3bf91?usp... : PS1, Line 11: For adding chip model support, we add in commit message testing info: which programmer you were using, operations that you run (most likely would be read/write/erase, but list the operation that you tested).
File include/flashchips.h:
https://review.coreboot.org/c/flashrom/+/83180/comment/74fd1d0b_cdfce26e?usp... : PS1, Line 856: #define XMC_XM25QU80B 0x5014 Let's move the line up, put it on #850, after XMC_XM25QU64C. Otherwise it seems a bit out of order here.
https://review.coreboot.org/c/flashrom/+/83180/comment/0d4b0f48_6a60f43f?usp... : PS1, Line 856: 0x5014 The ID needs to be aligned with the others (see like other IDs all aligned in a column), so you need two tabs between macro name and ID.
-
Anastasia Klimchuk (Code Review)