[M] Change in flashrom[master]: amd_imc.c: Cleanup C89ism and redundant NULL check - flashrom-gerrit

25 May 2023


      Attention is currently required from: Edward O'Callaghan, Martin Roth.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/75359 )
Change subject: amd_imc.c: Cleanup C89ism and redundant NULL check
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
File amd_imc.c:
https://review.coreboot.org/c/flashrom/+/75359/comment/c496752b_ed30f8e9 
PS2, Line 39: 	if (!dev) {
            : 		return 0;
            : 	}
We should keep this check. Let's re-add it in `imc_resume()` and `amd_imc_shutdown()`  to be safe, the other functions should only called from within this file.
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/75359
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I1dbae500010fa50a67609efb3cbb5778b684ad04
Gerrit-Change-Number: 75359
Gerrit-PatchSet: 2
Gerrit-Owner: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Martin Roth martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Edward O'Callaghan quasisec@chromium.org
Gerrit-Attention: Martin Roth martin.roth@amd.corp-partner.google.com
Gerrit-Comment-Date: Thu, 25 May 2023 09:25:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment