Attention is currently required from: Edward O'Callaghan, Angel Pons, Neill Corlett. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/61288 )
Change subject: Add mediatek_i2c_spi interface ......................................................................
Patch Set 2:
(2 comments)
Patchset:
PS1:
- We had two different board designs, one of which connects the TSUM* to SMBus and the other to raw I2C. This driver is tested on both. The finished product will be using I2C. I've left the SMBus code in as a convenience so we can continue to flash our earlier prototypes.
Ah, hmmm, I'm not sure but I think there are SMBus controller drivers that could still advertise I2C_FUNC_I2C. Can you please confirm that this is not the case. Or can you tell us what controller is used specifically?
Also, is the chip aware if it is connected over SMBus or I2C, e.g. by a pin strap?
- GPIO numbers are specific to TSUMOP82JUQ. My understanding is that these particular GPIO lines, for that chip, are standard for connecting to SPI WP#. Documentation that we received from PanVision just says to poke them and doesn't provide further detail.
Who is PanVision in this story? Did they acquire the MSTAR chip line and provide the chips? or do they provide the board? or ...?
Also, where do you use these chips, integrated display or something external? If you used SMBus, is it even on the mainboard?
File mediatek_i2c_spi.c:
https://review.coreboot.org/c/flashrom/+/61288/comment/e2d50ac8_de21b96a PS1, Line 96: args.data->block
I imagine Edward would like to avoid pointer arithmetics, substituting `args. […]
I would use `args.data->block + 1` when targeting an array and `&args.data->block[1]` only if I target a single member.
-
Nico Huber (Code Review)