Attention is currently required from: Felix Singer, Thomas Heijligen, Angel Pons, Alexander Goncharov.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67700 )
Change subject: stlinkv3_spi: fix uninitialized pointer ......................................................................
Patch Set 2: Code-Review+2
(1 comment)
Patchset:
PS1:
Huh? […]
I spent some time trying to understand this very eloquent conversation :D
I looked into alternative patch CB:66225 and I see that Felix pushed the latest patchset which makes it almost the same as this patch (that's probably what the first huh means). This patch, however has a comment, which I think is good, good to have a comment (that's probably the second huh).
So technically there are two options what to do: 1) Click Submit for this patch, abandon CB:66225 2) Felix uploads one more patchset to CB:66225, with a comment, which would make CB:66225 identical to this one. Then click submit on CB:66225 and abandon this one.
Just from purely technical perspective 1) looks easier. If CB:66225 would be mine, I would just say yeah let's abandon. But it is not mine, started by another contributor, and yes it was pushed earlier. I vote for 1) and I can write a nice comment to CB:66225 explaining what has happened. What do other people think?
-
Anastasia Klimchuk (Code Review)