Attention is currently required from: Felix Singer, Angel Pons, Anastasia Klimchuk. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/64028 )
Change subject: meson: use built-in options for install paths ......................................................................
Patch Set 2:
(2 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/64028/comment/f6821f09_57dee8c1 PS2, Line 13: Signed-off-by: Thomas Heijligen thomas.heijligen@secunet.com
The "Owner" in the left top corner just refers to the Gerrit user who pushed the commit.
As Felix said, The owner is just the Gerrit handle and here I'm using my private account as may others. The "Signed-of-by" with my work address is to say, this contribution is done as part of my job and not my personal one. The copyright is by my employer and not only by myself. Also it demonstrate that the company is involved in open source development.
File meson.build:
https://review.coreboot.org/c/flashrom/+/64028/comment/3e9a962e_ae7fad28 PS2, Line 408: libdir = join_paths(prefix, get_option('libdir'))
So `libdir` was unused?!
Yes
-
Thomas Heijligen (Code Review)