Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons, Daniel Campello, Peter Marheine.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/59532 )
Change subject: tests: Add test for extract operation
......................................................................
Patch Set 4:
(3 comments)
This change is ready for review.
File tests/chip.c:
https://review.coreboot.org/c/flashrom/+/59532/comment/9ea6647b_623bee71
PS3, Line 462: mock_chip.total_size * 1024;
flashrom_flash_getsize() ?
That's a good idea, and gives more coverage :)
https://review.coreboot.org/c/flashrom/+/59532/comment/47ec7e9c_08d74bb8
PS3, Line 464:
trim
Done
https://review.coreboot.org/c/flashrom/+/59532/comment/c0be707c_f73d21d1
PS3, Line 468: printf("Extract layout operation done.\n");
you probably want to validate buf now contains the read content? […]
Done
--
To view, visit
https://review.coreboot.org/c/flashrom/+/59532
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I13107c0e095d53184e32a41fa72227cf7dc1d449
Gerrit-Change-Number: 59532
Gerrit-PatchSet: 4
Gerrit-Owner: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Daniel Campello
campello@chromium.org
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Peter Marheine
pmarheine@chromium.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Daniel Campello
campello@chromium.org
Gerrit-Attention: Peter Marheine
pmarheine@chromium.org
Gerrit-Comment-Date: Thu, 03 Mar 2022 06:21:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Edward O'Callaghan
quasisec@chromium.org
Gerrit-MessageType: comment