Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/28716 )
Change subject: Rework internal bus handling and laptop bail-out
......................................................................
Patch Set 5:
(2 comments)
Rebased again (properly, I hope) and added a commit message.
https://review.coreboot.org/#/c/28716/1/chipset_enable.c
File chipset_enable.c:
https://review.coreboot.org/#/c/28716/1/chipset_enable.c@773
PS1, Line 773:
Yes?
Done by rebase?
https://review.coreboot.org/#/c/28716/1/internal.c
File internal.c:
https://review.coreboot.org/#/c/28716/1/internal.c@283
PS1, Line 283: proped
proped? Maybe probed?
Done
--
To view, visit
https://review.coreboot.org/c/flashrom/+/28716
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I1dbda8cf0c10d7786106f14f0d18c3dcce35f0a3
Gerrit-Change-Number: 28716
Gerrit-PatchSet: 5
Gerrit-Owner: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 03 Jun 2019 22:26:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment