Attention is currently required from: Felix Singer, Thomas Heijligen, Anastasia Klimchuk.
Alexander Goncharov has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/68247 )
Change subject: util: add bash completion script ......................................................................
Patch Set 7:
(3 comments)
File Makefile:
https://review.coreboot.org/c/flashrom/+/68247/comment/4a0228aa_f85f727e PS4, Line 33: bash-completion
oops.. That comment should have gone to the other thread.
I mark it as resolved. Feel free to reopen =)
File meson.build:
https://review.coreboot.org/c/flashrom/+/68247/comment/6a8d82b5_02a85073 PS4, Line 611: share/bash-completion/completions
Do you want me to add an option for bash-completion/completions ? […]
I went through sources at the link that Thomas sent (btw many thanks). Getting the path from a pkgconfig variable is a really nice way. Would it be enough?
File meson.build:
https://review.coreboot.org/c/flashrom/+/68247/comment/616cbfe7_b6b07f6d PS6, Line 607: if get_option('bash_completion').auto() or get_option('bash_completion').enabled()
If `classic_cli` is disabled and this is enabled it should give an error. […]
Thanks, I forgot about that. Done.
-
Alexander Goncharov (Code Review)