Attention is currently required from: Michael Heimpold, Nikolai Artemiev, Stefan Reinauer.
Anastasia Klimchuk has posted comments on this change by Michael Heimpold. ( https://review.coreboot.org/c/flashrom/+/82715?usp=email )
Change subject: flashchips: add support for chip model Winbond W25Q16JV_M ......................................................................
Patch Set 1:
(3 comments)
Patchset:
PS1: Thank you for your contribution. I have just two comments.
File flashchips.c:
https://review.coreboot.org/c/flashrom/+/82715/comment/b4c70817_230f1409?usp... : PS1, Line 19297: FEATURE_WRSR_EXT2 | You need to remove this feature bit, it's not needed.
For the operation of writing the second bit of status register, you have FEATURE_WRSR2 and that's correct from the datasheets.
(FEATURE_WRSR_EXT2 would be an alternative way, which is not for this chip).
https://review.coreboot.org/c/flashrom/+/82715/comment/cc6801e5_ecddb6a9?usp... : PS1, Line 19320: SPI_PRETTYPRINT_STATUS_REGISTER_BP3_SRWD I think this function is better for this chip, it will print more details: `SPI_PRETTYPRINT_STATUS_REGISTER_SRWD_SEC_TB_BP2_WELWIP`
-
Anastasia Klimchuk (Code Review)