Attention is currently required from: Angel Pons, Light. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62764 )
Change subject: ich_descriptors.c: Ensure unsigned types >=0 on to prevent underflow error ......................................................................
Patch Set 14: Code-Review+1
(4 comments)
File ich_descriptors.c:
https://review.coreboot.org/c/flashrom/+/62764/comment/332894d1_2a900d04 PS14, Line 501: for (j = 0; j < (size_t)min(num_regions, 12); j++) Maybe these `12`'s should be a `#define MAX_NUM_REGIONS 12` or at the very least a constant after line 489.
https://review.coreboot.org/c/flashrom/+/62764/comment/2f096e3b_81b9061e PS14, Line 505: for (j = 12; j < num_regions; j++) ditto
https://review.coreboot.org/c/flashrom/+/62764/comment/31c31bf3_827fe455 PS14, Line 507: 12 ditto
https://review.coreboot.org/c/flashrom/+/62764/comment/1691e479_8c73d6e8 PS14, Line 508: 12 ditto