Attention is currently required from: Simon Buhrow, Nico Huber, Thomas Heijligen, Paul Menzel.
Aarya has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/66104 )
Change subject: flashrom.c: Add wrapper function to use the erase algorithm
......................................................................
Patch Set 61:
(3 comments)
File flashrom.c:
https://review.coreboot.org/c/flashrom/+/66104/comment/04d85245_6a9c619f
PS52, Line 1057: flashctx->chip->page_size
gran is just an enum, so I don't think it is needed here
Done
https://review.coreboot.org/c/flashrom/+/66104/comment/cf46066d_6a412871
PS52, Line 1063: page_size
`gran`
Done
File flashrom.c:
https://review.coreboot.org/c/flashrom/+/66104/comment/be9a0036_ea3004f4
PS54, Line 1244: assert(!ret);
This assert get triggered by the unit tests. […]
Done
--
To view, visit
https://review.coreboot.org/c/flashrom/+/66104
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I29e3f2bd796759794184b125741a5abaac6f3ce8
Gerrit-Change-Number: 66104
Gerrit-PatchSet: 61
Gerrit-Owner: Aarya
aarya.chaumal@gmail.com
Gerrit-Reviewer: Simon Buhrow
Gerrit-Reviewer: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Anastasia Klimchuk
aklm@chromium.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Simon Buhrow
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Thomas Heijligen
src@posteo.de
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Comment-Date: Thu, 29 Sep 2022 15:41:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Thomas Heijligen
src@posteo.de
Comment-In-Reply-To: Aarya
aarya.chaumal@gmail.com
Gerrit-MessageType: comment