Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/28685 )
Change subject: Add CLI option to include a numeric range
......................................................................
Patch Set 1:
How about a more implicit approach: Allow region names matching the pattern: <start>..<end> ? Whenever a region name isn't found but matches that pattern, flashrom could generate a region on the fly.
Downside: Somebody could make funny things by adding a layout file entry with such a name. But we could warn about that when parsing a layout file, ofc.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/28685
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ie2691051984bdeac128354c09bbe72aa05ef7401
Gerrit-Change-Number: 28685
Gerrit-PatchSet: 1
Gerrit-Owner: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 19 Dec 2018 14:16:06 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment